TST: Add test for assert_frame_equal when nested DataFrame contains NA #62628
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
requested changes
Oct 15, 2025
|
|
||
| def test_assert_frame_equal_nested_df_na(): | ||
| # GH#43022 | ||
| inner = DataFrame({"a": [1, pd.NA]}) |
There was a problem hiding this comment.
It appears the original issue tests with np.nan. Could you pytest.mark.parametrize this test with np.nan and pd.NA?
There was a problem hiding this comment.
Done, and also added None
mroeschke
added
the
Testing
mroeschke
approved these changes
Oct 15, 2025
|
Thanks @jzwick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pd.testing.assert_frame_equalfails if nestedDataFramecontainsnp.nan#43022doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This PR adds a test for a reported issue (first reported 4years ago) which is no longer present on main. Adding this test ensures that the behavior remains and isn't accidentally reverted.
I think maybe this is the PR that fixed the issue - I tried to confirm but ran into build issues when trying to build from before that commit from nearly 3years ago.